You've already forked caddy-opnsense-blocker
Fix IP details page JavaScript quoting
This commit is contained in:
@@ -77,6 +77,20 @@ func TestHandlerServesOverviewAndManualActions(t *testing.T) {
|
||||
if strings.Contains(recorder.Body.String(), "Recent events") {
|
||||
t.Fatalf("overview page should no longer render recent events block")
|
||||
}
|
||||
|
||||
recorder = httptest.NewRecorder()
|
||||
request = httptest.NewRequest(http.MethodGet, "/ips/203.0.113.10", nil)
|
||||
handler.ServeHTTP(recorder, request)
|
||||
if recorder.Code != http.StatusOK {
|
||||
t.Fatalf("unexpected ip details page status: %d", recorder.Code)
|
||||
}
|
||||
body := recorder.Body.String()
|
||||
if !strings.Contains(body, `data-ip="203.0.113.10"`) {
|
||||
t.Fatalf("ip details page did not expose expected data-ip attribute: %s", body)
|
||||
}
|
||||
if strings.Contains(body, `const ip = "\"203.0.113.10\"";`) {
|
||||
t.Fatalf("ip details page still renders a doubly quoted IP")
|
||||
}
|
||||
}
|
||||
|
||||
type stubApp struct {
|
||||
|
||||
Reference in New Issue
Block a user